• src/sbbs3/qwktomsg.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Nov 15 21:30:02 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ed1f4ab1828f06a5b2369200
    Modified Files:
    src/sbbs3/qwktomsg.cpp
    Log Message:
    Initialize time zone variable (zone)

    As found and reported by Talisam author, apam (HAPPYLND).

    sscanf() won't initialize the buffer of the argument passed if the format string is not matched, so when there was no hexadecimal/SMB timezone value, the timezone specified in the ISO date/time string (if any) would be overwritten with 0, converted from the uninitialized 'zone' variable (unlikely to be valid hex-ASCII chars). Thanks apam!

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu Apr 4 18:06:02 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/fa91e9074a14a892557b7606
    Modified Files:
    src/sbbs3/qwktomsg.cpp
    Log Message:
    Default FTN charset to CP437 (not ASCII) for QWK-imported messages

    A QWKnet tagline usually contains CP437 character 254 and if/when appended to
    a message during export, would "convert" the message to CP437 thus making the "ASCII" charset advertisement incorrect.

    If a FIDO CHARSET value was already specified (e.g. in HEADERS.DAT), that
    value will (still) not be overridden. So the *original* import via QWK (before it gets exported to a QWKnet) is where this change will take effect.

    Fix for issue #741

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net