• src/sbbs3/load_cfg.c

    From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Sep 25 16:36:18 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/566c41b6ab3cbbe97fc25009
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Allow text strings to be identified by number (instead of ID)

    for those that want to use cryptic numbers rather than human-readable names.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Sep 25 17:39:43 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b44b6ea733cd12a51560b980
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix off-by-one issue in previous commit, text.dat string numbers are 1-based

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 18 21:48:11 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/4197ced7afc511120e8d284b
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix new crash on startup for Windows build

    load_cfg() calls free_cfg() before do_cryptInit() is called, so the ssl_rwlock was uninitialized here.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 18 21:51:09 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c15b7a2f57ccf21ad44f7e3c
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix new clang warning: incompatible pointer types passing 'long *' to parameter of type 'int *'

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Tue Dec 19 01:29:23 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/587eca57b14dc020487c22d8
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    We don't need to set tls_certificate to -1 in prep_cfg() because
    it's only called from load_cfg() which has already set it to -1.

    We also don't need to check prepped twice to make sure it's extra true.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Dec 19 01:31:01 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d47a2258d7f870e139cdf0b4
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Always set scfg.prepped to FALSE in free_cfg()

    Remove some redundant redundancies, redundantly

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Jan 23 12:17:37 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/0503c2900a17ddd91986b312
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix uninitialized cfg.colors[] element usage caught by Deuce (and Clang?)

    Conditional jump or move depends on uninitialised value(s)
    at 0x4AE768D: sbbs_t::backfill(char const*, float, int, int) (con_out.cpp:1445)
    by 0x4AE7855: sbbs_t::progress(char const*, int, int, int) (con_out.cpp:1467)
    by 0x4AE91A9: ProgressLoadingMsgPtrs(void*, int, int) (data_ovl.cpp:27)
    by 0x4C7C577: getmsgptrs (userdat.c:3972)
    by 0x4AE9144: sbbs_t::getmsgptrs() (data_ovl.cpp:39)
    by 0x4BF9237: sbbs_t::logon() (logon.cpp:452)
    by 0x4AC1CE2: sbbs_t::answer() (answer.cpp:636)
    by 0x4C0FD37: node_thread(void*) (main.cpp:4277)

    Introduced in commit 48e7520e (when colors was converted from a byte array
    to a uint array), we weren't memsetting the right number of bytes.

    Since color is not an array of ints (not bytes), memset (of non-zero values) isn't really the right initialization approach anyway. Now using a for-loop.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net