• SlyEdit: More small tweaks for quote line wrapping to determine ideal

    From Rob Swindell@VERT to GitLab note in main/sbbs on Thu Aug 17 11:30:30 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/316#note_3794

    Have you considered just using the word_wrap function built into SBBS? It handles quoted lines already.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Eric Oulashin@VERT to GitLab note in main/sbbs on Thu Aug 17 11:58:44 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/316#note_3795

    This actually does use word_wrap (line 2946). The issue I found with word_wrap is that it there are some quoted lines in some messages it doesn't handle very well. word_wrap seems to work relatively well if the quote prefixes are " > ", but if the quote prefix for a section of a message is a bit different (i.e., with author's initials or other characters before the >), word_wrap doesn't seem to take that into account. This word wrap function I wrote looks for different sections in the message with various quote prefixes and uses word_wrap() on each section (without that section's prefix) and then prepends the prefix back onto that section.

    I've seen some more variation in quote prefixes on FSXNet. For instance, some messages are quoted with "-> ", and some have multiple things where people have quoted lines that have been already quoted (such as "-> Av> ", or " Bu> cl> "). In messages with such quote prefixes, especially multiple different prefixes for different quoted sections, word_wrap often didn't preserve some of those quote prefixes in front of the quoted sections of the messages.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Eric Oulashin@VERT to GitLab note in main/sbbs on Thu Aug 17 12:57:44 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/316#note_3797

    Also, if a message has multiple quoted sections with different prefixes for each section, that's an instance where word_wrap() doesn't seem to account for the quote prefixes and could include the prefixes in the wrapped text

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Thu Aug 17 14:11:12 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/316#note_3798

    Okay, I just wanted to make sure use of word_wrap() as being considered (or done).

    I haven't really observed the issues you're describing while using fseditor.js, but I'm also usually using it at 80 columns and maybe that's why.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Eric Oulashin@VERT to GitLab note in main/sbbs on Thu Aug 17 14:23:15 2023
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/316#note_3800

    I also use 80 columns most of the time.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net