• exec/load/binkp.js

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Nov 4 10:24:17 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/4dd32231f18bcb4f67833c36
    Modified Files:
    exec/load/binkp.js
    Log Message:
    Resolve undetected or infinitely-retried socket-send failures

    My hub (1:218/700) is currently having what appears to be a TCP/IP
    connectivity issue that was resulting in infinite "Send failure"
    log messages and "We got an M_EOB, but there are still N files pending M_GOT" log messages.

    I first added better socket-send failure detection (checking return value of sendCmd() and sendData() where needed) and then noticed that failure to send
    a file was not detected (the sending.file.position is advanced even if sendData() fails), so now handling that condition too.

    Also added more diagnostics around socket-send failures (is socket writable?) in this particular case, the socket is not writable and socket-send is returning 0.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Nov 28 12:18:49 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/c3a41492a79aa3c6b3a41b37
    Modified Files:
    exec/load/binkp.js
    Log Message:
    More errno details in file open and socket-send failure warning log msgs

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Nov 28 12:57:49 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/0ea1ce1d2600b79a77d41b7e
    Modified Files:
    exec/load/binkp.js
    Log Message:
    Use socket.poll() to check socket for writability before send()

    This is the real fix for infinite-wait on send() problem that was attempted
    in commit f0127e9d457, but caused other issues. Thanks Deuce.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net